Skip to content

Update iojs to v1.5.1#543

Merged
yosifkit merged 1 commit into
docker-library:masterfrom
pesho:master
Mar 10, 2015
Merged

Update iojs to v1.5.1#543
yosifkit merged 1 commit into
docker-library:masterfrom
pesho:master

Conversation

@pesho

@pesho pesho commented Mar 10, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@tianon

tianon commented Mar 10, 2015

Copy link
Copy Markdown
Member

LGTM (nodejs/docker-iojs@595501c...cee0ed5)

I wonder if there's a way to set --loglevel info via a configuration default instead so that it applies even if people don't use the onbuild variant.

Build test of #543; f2163a3 (iojs):

$ url="https://raw.githubusercontent.com/docker-library/official-images/f2163a38ef600ff915e6181e23f28135d6259a7a/library/iojs"
$ bashbrew build "$url"
Fetching iojs (git://github.com/iojs/docker-iojs) ...
Processing iojs:1.5.1 ...
Processing iojs:1.5 ...
Processing iojs:1 ...
Processing iojs:latest ...
Processing iojs:1.5.1-onbuild ...
Processing iojs:1.5-onbuild ...
Processing iojs:1-onbuild ...
Processing iojs:onbuild ...
Processing iojs:1.5.1-slim ...
Processing iojs:1.5-slim ...
Processing iojs:1-slim ...
Processing iojs:slim ...
$ bashbrew list "$url" | xargs test/run.sh
testing iojs:1.5.1
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing iojs:1.5
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing iojs:1
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing iojs:latest
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing iojs:1.5.1-onbuild
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing iojs:1.5-onbuild
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing iojs:1-onbuild
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing iojs:onbuild
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing iojs:1.5.1-slim
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing iojs:1.5-slim
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing iojs:1-slim
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing iojs:slim
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed

@Starefossen

Copy link
Copy Markdown
Contributor

I wonder if there's a way to set --loglevel info via a configuration default instead so that it applies even if people don't use the onbuild variant.

That would be a better approach, and I found the following in the npm config docs:

Any environment variables that start with npm_config_ will be interpreted as a configuration parameter. For example, putting npm_config_foo=bar in your environment will set the foo configuration parameter to bar. Any environment configurations that are not given a value will be given the value of true. Config values are case-insensitive, so NPM_CONFIG_FOO=bar will work the same.

I have tested it with the following which works great:

env NPM_CONFIG_LOGLEVEL info

@yosifkit

Copy link
Copy Markdown
Member

LGTM

yosifkit added a commit that referenced this pull request Mar 10, 2015
@yosifkit yosifkit merged commit 3d40068 into docker-library:master Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants