Skip to content

Unexport volume commands#6321

Merged
Benehiko merged 1 commit into
docker:masterfrom
Benehiko:command/volume
Aug 20, 2025
Merged

Unexport volume commands#6321
Benehiko merged 1 commit into
docker:masterfrom
Benehiko:command/volume

Conversation

@Benehiko

@Benehiko Benehiko commented Aug 20, 2025

Copy link
Copy Markdown
Member

This patch deprecates exported volume commands and moves the implementation details to an unexported function.

Commands that are affected include:

  • volume.NewVolumeCommand
  • volume.NewPruneCommand

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

Go SDK: cli/command/volume: deprecate `NewVolumeCommand`, `NewPruneCommand`. These functions will be removed in the next release.

- A picture of a cute animal (not mandatory but encouraged)

This patch deprecates exported volume commands and moves the implementation
details to an unexported function.

Commands that are affected include:

- volume.NewVolumeCommand
- volume.NewPruneCommand

Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
@Benehiko Benehiko requested a review from thaJeztah August 20, 2025 10:58
@Benehiko Benehiko added impact/changelog impact/deprecation kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Aug 20, 2025
@Benehiko Benehiko enabled auto-merge August 20, 2025 10:59
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/volume/cmd.go 0.00% 10 Missing ⚠️
cli/command/volume/prune.go 66.66% 2 Missing ⚠️
cli/command/commands/commands.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thaJeztah thaJeztah added this to the 29.0.0 milestone Aug 20, 2025

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Benehiko Benehiko merged commit 89316e1 into docker:master Aug 20, 2025
117 of 124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdk Changes affecting the Go SDK impact/changelog impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code process/cherry-picked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants