Add lean TUI user setting#3181
Merged
Merged
Conversation
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Reviewed changes across cmd/root/run.go, cmd/root/sandbox.go, pkg/userconfig/userconfig.go, and associated tests for the settings.lean user config feature.
No bugs found. The implementation correctly:
- Applies
settings.lean: trueas a low-priority default (only when the user hasn't explicitly set--lean) - Preserves explicit CLI overrides including
--lean=false - Forwards explicit
falsebool flags correctly in sandboxed runs - Documents the new config option in
docs/features/tui/index.md
The priority/precedence logic, flag propagation, and test coverage all look sound.
d1c441e to
68ab5b6
Compare
aheritier
approved these changes
Jun 19, 2026
pull Bot
pushed a commit
to TheTechOddBug/cagent
that referenced
this pull request
Jun 20, 2026
Adds an Unreleased section to CHANGELOG.md for PR docker#3181, which landed after the v1.83.0 cut and adds settings.lean to the user config file. The TUI feature page already documents the setting; this commit records the change in the changelog. Source: docker#3181
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a global
settings.leanuser config option so users can make the lean TUI the default for interactive runs.settings.lean: trueas a low-priority default--lean=falseTesting:
go test ./pkg/userconfig/...go test ./cmd/root ./pkg/userconfig ./pkg/leantui ./pkg/tui./scripts/build.shgo run ./lint .go mod tidy --diffFull
go test ./...was attempted but hit unrelated environment/pre-existing failures: localhost DNS,pkg/cache, andpkg/rag/treesitterCGO.