refactor: make toolsets and providers explicit#3184
Merged
Conversation
Sayt-0
approved these changes
Jun 20, 2026
|
❌ PR Review Failed — The review agent encountered an error and could not complete the review. View logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registry patterns for toolsets and providers have been implicit, relying on blank imports and init() functions to wire everything together. This refactor makes both registries explicit.
Providers now live behind a *provider.Registry which must be passed around explicitly. Similarly, toolsets are registered in pkg/teamloader/toolsets/NewDefaultToolsetRegistry(), removing the hidden coupling through blank imports in cmd/root/toolsets.go. The rag toolset, which pulls in cgo dependencies, is now available only when explicitly included via the registry.