Skip to content

PB-2114: Add tracing#624

Merged
msom merged 1 commit into
developfrom
feat-PB-2114-tracing
Jan 22, 2026
Merged

PB-2114: Add tracing#624
msom merged 1 commit into
developfrom
feat-PB-2114-tracing

Conversation

@msom

@msom msom commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Adds tracing for WSGI and management commands.

The following instrumentations can be enabled using a flag:

  • Django
  • Boto
  • Psycopg
  • Logging

@msom msom marked this pull request as draft January 12, 2026 15:55
@msom msom force-pushed the feat-PB-2114-tracing branch 4 times, most recently from 2a53a6f to f3d8756 Compare January 20, 2026 08:08
@msom msom marked this pull request as ready for review January 20, 2026 08:09
@adk-swisstopo

Copy link
Copy Markdown
Member

We looked into this with @ltflb-bgdi back in October and ISTR there was some complications to expect. I will need some time to reload context and figure out whether that's properly addressed but if you did look into this and have words to convince me it's all going to work fine under load and is properly supported, please write them down :)

@msom

msom commented Jan 20, 2026

Copy link
Copy Markdown
Contributor Author

We looked into this with @ltflb-bgdi back in October and ISTR there was some complications to expect. I will need some time to reload context and figure out whether that's properly addressed but if you did look into this and have words to convince me it's all going to work fine under load and is properly supported, please write them down :)

I'm confident that it works as it's already done with service-control. Not confident that it will work under load, I will approach you regarding how to performance test this if that is ok for you?

@adk-swisstopo

Copy link
Copy Markdown
Member

I think I was hoping to remove our custom monkey patching or switch to another web server before we get to this point as I suspect it might cause more weird interactions. Obviously we are not going to do that (at least not in time).

Comment thread app/wsgi.py Outdated
@msom msom force-pushed the feat-PB-2114-tracing branch from f3d8756 to 31e8c97 Compare January 20, 2026 10:32
@msom msom requested a review from KeeTraxx January 20, 2026 10:32

@KeeTraxx KeeTraxx left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, thanks!

@adk-swisstopo adk-swisstopo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my favourite approach but if it works and you validate it with load testing, I guess it will do.

@msom

msom commented Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

Looks good at first glance, I'll merge it and test it some more on DEV and next week on INT.

@msom msom merged commit 5fbbd18 into develop Jan 22, 2026
3 checks passed
@msom msom deleted the feat-PB-2114-tracing branch January 22, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants