ref(node): Streamline connect#21404
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Move the ported utils tests into a connect/ folder and add instrumentation.test.ts (fake-driven span-creation cases). Replace the no-this-alias suppressions with bound-method captures; only the two unbound-method false-positives remain disabled. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Remove the fake-driven instrumentation test; the integration suite now covers named + anonymous middleware spans with the real package. Keep the pure-function utils test, relocated to connect.test.ts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Type the remaining `any`s as `unknown` (forwarding via `Reflect.apply`) and remove the connect entry from the oxlint exemption list. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubec
commented
Jun 10, 2026
|
|
||
| expect.objectContaining({ | ||
| data: expect.objectContaining({ | ||
| 'connect.name': 'middleware1', |
Member
Author
There was a problem hiding this comment.
not sure if we should clean out stuff like this too, the product has no use for these but it's technically breaking
Member
There was a problem hiding this comment.
IMHO I'd leave such things as much as possible if we think they could be helpful/useful, no need to drop stuff that somebody could use.
Cover the `isErrorMiddleware` branch by asserting the `connectErrorMiddleware` span in the errored-transaction test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replace the OTel tracer/context span lifecycle with `startInactiveSpan` from `@sentry/core`, and mark middleware spans as errored (throw or `next(err)`). Swap the remaining `diag.warn` for the Sentry debug logger. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Move the Sentry op/origin/name off the `addConnectSpanAttributes` spanStart hook into the `startInactiveSpan` call, so they're set unconditionally (the hook only ran when `setupConnectErrorHandler` was used). Drop the now-unused `ConnectNames` enum and the hook. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Guard the `next(err)` path with `isError` so routing signals like
`next('route')` don't mark the span as errored.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
👋 @JPeer264, @andreiborza — Please review this PR when you get a chance! |
mydea
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlines the vendored
@opentelemetry/instrumentation-connect:Closes #20724