feat(deno): Add orchestrion deno runtime hook#21451
Merged
Merged
Conversation
d6de7a3 to
0ceae6a
Compare
39be3da to
b34aa87
Compare
0ceae6a to
2011bb7
Compare
b34aa87 to
653fc0e
Compare
2011bb7 to
8ab5b64
Compare
Contributor
JPeer264
approved these changes
Jun 15, 2026
JPeer264
left a comment
Member
There was a problem hiding this comment.
LGTM, just two minor comments
| ``` | ||
|
|
||
| > [!NOTE] | ||
| > In Deno versions **2.8.0** through **2.8.2**, a bug causes Deno |
Member
There was a problem hiding this comment.
q: Is it worth to mention that it works in these two versions? I would be fine of just saying we are supporting everything after 2.8.3 with the --import option and don't go into much detail - but this is also ok.
Member
There was a problem hiding this comment.
I generally agree that I'd just say "we support deno 2.8.3 and above" and not really go into details for anything below that?
| * orchestrion runtime hook (`@sentry/deno/import`) needs to transform libraries | ||
| * like `mysql` so they publish to their tracing channels. | ||
| */ | ||
| export const MODULE_REGISTER_HOOKS_SUPPORTED = gte(2, 8, 0); |
Member
There was a problem hiding this comment.
q/l: Connected to the other comment. Should we actually start supporting it form 2.8.3?
Member
Author
There was a problem hiding this comment.
I mean, it's fine, I guess? Probably no one's going to be using Deno 2.8.0, but they did make a big announcement about it when it came out, and haven't been as noisy about the patches, so it's possible someone upgraded right away, but then is lagging behind, I guess?
Member
There was a problem hiding this comment.
Ok if they made big announcements it might be better as is.
653fc0e to
8743326
Compare
8ab5b64 to
4f35ab9
Compare
b5a794a to
ac38662
Compare
4f35ab9 to
e54572f
Compare
Contributor
size-limit report 📦
|
ac38662 to
0cfd982
Compare
e54572f to
21830a7
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 21830a7. Configure here.
0cfd982 to
ccbd1b2
Compare
isaacs
added a commit
that referenced
this pull request
Jun 15, 2026
Use the orchestrion loader hook defined in server-utils, and create a loader for Deno that detects the presence of the hooks, and instruments the channels added to the mysql module. Documentation added to call out the caveat of usage in Deno v2.8.0 through 2.8.2, which is fixed in 2.8.3.
21830a7 to
1caca4f
Compare
isaacs
added a commit
that referenced
this pull request
Jun 16, 2026
Use the orchestrion loader hook defined in server-utils, and create a loader for Deno that detects the presence of the hooks, and instruments the channels added to the mysql module. Documentation added to call out the caveat of usage in Deno v2.8.0 through 2.8.2, which is fixed in 2.8.3.
1caca4f to
4be4406
Compare
mydea
reviewed
Jun 16, 2026
5b20801 to
4793bdc
Compare
5b4cb48 to
cfe1a03
Compare
isaacs
added a commit
that referenced
this pull request
Jun 17, 2026
Use the orchestrion loader hook defined in server-utils, and create a loader for Deno that detects the presence of the hooks, and instruments the channels added to the mysql module. Documentation added to call out the caveat of usage in Deno v2.8.0 through 2.8.2, which is fixed in 2.8.3.
4793bdc to
6b86f67
Compare
cfe1a03 to
568911f
Compare
isaacs
added a commit
that referenced
this pull request
Jun 18, 2026
Use the orchestrion loader hook defined in server-utils, and create a loader for Deno that detects the presence of the hooks, and instruments the channels added to the mysql module. Documentation added to call out the caveat of usage in Deno v2.8.0 through 2.8.2, which is fixed in 2.8.3.
6b86f67 to
1714284
Compare
isaacs
added a commit
that referenced
this pull request
Jun 18, 2026
Use the orchestrion loader hook defined in server-utils, and create a loader for Deno that detects the presence of the hooks, and instruments the channels added to the mysql module. Documentation added to call out the caveat of usage in Deno v2.8.0 through 2.8.2, which is fixed in 2.8.3.
1714284 to
79c1076
Compare
568911f to
69a65aa
Compare
|
Semgrep found 1 Risk: Affected versions of esbuild are vulnerable to Download of Code Without Integrity Check / Untrusted Search Path. esbuild's Deno distribution module ( Manual Review Advice: A vulnerability from this advisory is reachable if you invoke the esbuild Deno module directly as a CLI tool (e.g. Fix: Upgrade this library to at least version 0.28.1 at sentry-javascript/yarn.lock:15987. Reference(s): GHSA-gv7w-rqvm-qjhr |
69a65aa to
ea45a82
Compare
isaacs
added a commit
that referenced
this pull request
Jun 18, 2026
Use the orchestrion loader hook defined in server-utils, and create a loader for Deno that detects the presence of the hooks, and instruments the channels added to the mysql module. Documentation added to call out the caveat of usage in Deno v2.8.0 through 2.8.2, which is fixed in 2.8.3.
79c1076 to
43ae63a
Compare
2c1a850 to
54e9bb3
Compare
isaacs
added a commit
that referenced
this pull request
Jun 18, 2026
Use the orchestrion loader hook defined in server-utils, and create a loader for Deno that detects the presence of the hooks, and instruments the channels added to the mysql module. Documentation added to call out the caveat of usage in Deno v2.8.0 through 2.8.2, which is fixed in 2.8.3.
43ae63a to
116ecbd
Compare
isaacs
added a commit
that referenced
this pull request
Jun 18, 2026
Use the orchestrion loader hook defined in server-utils, and create a loader for Deno that detects the presence of the hooks, and instruments the channels added to the mysql module. Documentation added to call out the caveat of usage in Deno v2.8.0 through 2.8.2, which is fixed in 2.8.3.
116ecbd to
3acab72
Compare
90c3233 to
a8f426c
Compare
Use the orchestrion loader hook defined in server-utils, and create a loader for Deno that detects the presence of the hooks, and instruments the channels added to the mysql module. Documentation added to call out the caveat of usage in Deno v2.8.0 through 2.8.2, which is fixed in 2.8.3.
3acab72 to
26e55bd
Compare
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the orchestrion loader hook defined in server-utils, and create a loader for Deno that detects the presence of the hooks, and instruments the channels added to the mysql module.
Documentation added to call out the caveat of usage in Deno v2.8.0 through 2.8.2, which is fixed in 2.8.3.