ref(opentelemetry): Use @sentry/conventions#21495
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
ef58787 to
daea6f6
Compare
625467a to
2a83a9f
Compare
Member
|
Will review again once this is not a draft anymore. The changes as of now looks good, build is failing though. |
daea6f6 to
ed4204f
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ed4204f. Configure here.
5b79768 to
4079ff8
Compare
Contributor
|
👋 @JPeer264, @nicohrubec, @andreiborza — Please review this PR when you get a chance! |
andreiborza
approved these changes
Jun 17, 2026
nicohrubec
approved these changes
Jun 17, 2026
| import { SERVICE_NAME, SERVICE_VERSION } from '@sentry/conventions/attributes'; | ||
| import { SDK_VERSION } from '@sentry/core'; | ||
|
|
||
| // These resource attributes are not (yet) part of `@sentry/conventions`, so we inline the |
Member
There was a problem hiding this comment.
are there PRs for these yet?
Member
Author
There was a problem hiding this comment.
no, and likely will not because this is really an otel specific thing and can go away in v11!
JPeer264
approved these changes
Jun 17, 2026
4079ff8 to
bc376d2
Compare
Source span/attribute keys from `@sentry/conventions` as a regular dependency (externalized at build time, resolved at runtime). No functional change. Maps the `@sentry/conventions/attributes` subpath in the shared TS config for the repo's `node` moduleResolution type builds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bc376d2 to
c381c5e
Compare
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches
@sentry/opentelemetryto source span/attribute keys from@sentry/conventions, added as a regular runtimedependencyand externalized at build time (resolved at runtime by the consumer's installed copy). No functional change — the attribute values are identical.Part of splitting the larger
@sentry/conventionsmigration into per-package PRs.Ref: #20982