ref(node): Streamline mongodb instrumentation#21619
Merged
logaretm merged 1 commit intoJun 18, 2026
Merged
Conversation
Contributor
size-limit report 📦
|
8c0b859 to
d79e1cd
Compare
d79e1cd to
d0846c8
Compare
JPeer264
approved these changes
Jun 18, 2026
| v4PatchConnectionPool, | ||
| v4UnpatchConnectionPool, | ||
| ), | ||
| new InstrumentationNodeModuleFile( |
Member
There was a problem hiding this comment.
q: Is there a specific reason why this is not needed anymore?
Member
Author
There was a problem hiding this comment.
Those are metrics only, they don't do spans
d0846c8 to
ad2a160
Compare
Streamlines the vendored `mongodb` instrumentation to use Sentry's span APIs instead of the OpenTelemetry tracing APIs, following the redis/pg/mongoose precedent. - Replace `tracer.startSpan` with `startInactiveSpan`, the `trace.getSpan(context.active())` + `requireParentSpan` guard with a `getActiveSpan()` check, `SpanStatusCode.ERROR` with `SPAN_STATUS_ERROR`, and the `context.with(...)`/`context.bind(...)` propagation with `withActiveSpan` (result-handler re-activation and the pool `checkOut` rebind). Drop `recordException` and the `_diag` logger. - Drop the OTel connection-usage metrics: the SDK wires up no `MeterProvider`, so `this.meter` is the no-op meter and every `add` was dead. Also removes the session and connect patches that existed only to feed those metrics (they create no spans, so span output is unchanged). - Drop the `SemconvStability` dual-emission and keep the OLD semconv attributes only (the STABLE path was env-gated behind `OTEL_SEMCONV_STABILITY_OPT_IN` and never enabled by the SDK). - Remove config the SDK never passes (`responseHook`, the configurable `dbStatementSerializer`, `requireParentSpan`); move the always-on statement serializer into the vendored code and bake the `auto.db.otel.mongo` origin into the span attributes instead of an `index.ts` responseHook. - Drop the blanket eslint-disable, type the module, and split the helpers (`utils.ts`) and wrap factories (`patches.ts`) out of the class to keep each vendored file within `max-lines`. Removes the config-passing `Mongo` unit test (its serializer logic is covered end-to-end by the integration suite) and extends the real suite with an error path: a server-rejected query asserts `status: 'internal_error'` with the origin and `db.statement` preserved.
ad2a160 to
c8f6e1a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c8f6e1a. Configure here.
| kind: SpanKind.CLIENT, | ||
| attributes, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Missing db span metadata
High Severity
startMongoSpan creates native Sentry spans with name mongodb.${operation} and no sentry.op attribute. Finished spans expose description from that name and op from sentry.op in attributes, unlike the prior OTel exporter path that inferred op: db and a statement-based description from db.system / db.statement.
Reviewed by Cursor Bugbot for commit c8f6e1a. Configure here.
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlines the vendored
mongodbinstrumentation to use Sentry's span APIs instead of the OpenTelemetry tracing APIs.