ci: Pin react-router latest and add eslint disable for deprecated attribute#21624
Merged
Conversation
react-router 8 requires React 19 (imports useOptimistic); the SDK does not support v8 yet. Both the react-router-7-framework (latest) and -instrumentation E2E canaries float to v8 against React 18 and fail the build. Pin them to the newest v7 release until v8 is supported. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
df14940 to
0dc5e03
Compare
mydea
approved these changes
Jun 18, 2026
Lms24
approved these changes
Jun 18, 2026
andreiborza
approved these changes
Jun 18, 2026
#21604 enabled typescript/no-deprecated and added disable comments across the codebase but missed this vendored hapi usage, breaking lint on develop. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
JPeer264
approved these changes
Jun 18, 2026
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is currently blocked with two unrelated failures:
Pinning react router and adding an eslint disable to unblock ci.