cmake : fix ui build with read-only source#24752
Merged
Merged
Conversation
Contributor
Author
|
Tested on macOS (arm64) — out-of-tree build from a read-only source: git clone --depth 1 https://github.com/ggml-org/llama.cpp.git /tmp/llama-ro
git -C /tmp/llama-ro fetch --depth 1 origin pull/24752/head
git -C /tmp/llama-ro checkout FETCH_HEAD
rm -rf /tmp/llama-ro/.git
chmod -R a-w /tmp/llama-ro
cmake -S /tmp/llama-ro -B /tmp/llama-build -DLLAMA_BUILD_UI=ON -DLLAMA_USE_PREBUILT_UI=OFF
cmake --build /tmp/llama-build --target llama-uiFull build log: https://gist.github.com/o7si/c466d6f6dfa3320feb58fa662af52b90 |
aldehir
approved these changes
Jun 18, 2026
allozaur
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building out-of-tree against a read-only source, UI provisioning runs npm in the source tree, so it fails creating
node_modulesthere. The fix stages the UI sources into a writable copy under the build dir and runs npm there, leaving the source tree untouched.Related issue: