Skip to content

cmake : fix ui build with read-only source#24752

Merged
allozaur merged 1 commit into
ggml-org:masterfrom
o7si:fix-ui-readonly-build
Jun 18, 2026
Merged

cmake : fix ui build with read-only source#24752
allozaur merged 1 commit into
ggml-org:masterfrom
o7si:fix-ui-readonly-build

Conversation

@o7si

@o7si o7si commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

When building out-of-tree against a read-only source, UI provisioning runs npm in the source tree, so it fails creating node_modules there. The fix stages the UI sources into a writable copy under the build dir and runs npm there, leaving the source tree untouched.

Related issue:

@github-actions github-actions Bot added the script Script related label Jun 18, 2026
@aldehir aldehir self-assigned this Jun 18, 2026
@CISC CISC requested a review from a team June 18, 2026 07:39
@o7si

o7si commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Tested on macOS (arm64) — out-of-tree build from a read-only source:

git clone --depth 1 https://github.com/ggml-org/llama.cpp.git /tmp/llama-ro
git -C /tmp/llama-ro fetch --depth 1 origin pull/24752/head
git -C /tmp/llama-ro checkout FETCH_HEAD
rm -rf /tmp/llama-ro/.git
chmod -R a-w /tmp/llama-ro
cmake -S /tmp/llama-ro -B /tmp/llama-build -DLLAMA_BUILD_UI=ON -DLLAMA_USE_PREBUILT_UI=OFF
cmake --build /tmp/llama-build --target llama-ui

Full build log: https://gist.github.com/o7si/c466d6f6dfa3320feb58fa662af52b90

@allozaur allozaur merged commit 32eddaf into ggml-org:master Jun 18, 2026
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

script Script related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants