Skip to content

Remotes popup#2350

Merged
extrawurst merged 15 commits into
gitui-org:masterfrom
robin-thoene:remotes-popup
Sep 18, 2024
Merged

Remotes popup#2350
extrawurst merged 15 commits into
gitui-org:masterfrom
robin-thoene:remotes-popup

Conversation

@robin-thoene

@robin-thoene robin-thoene commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

This Pull Request fixes/closes #2172 .

It changes the following:

  • new popups to interact with git remotes to
    • view remotes
    • add a new remote
    • edit an existing remote name
    • edit an existing remote url
    • delete an existing remote

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@extrawurst

This comment was marked as resolved.

@extrawurst

extrawurst commented Sep 17, 2024

Copy link
Copy Markdown
Collaborator

a command to fetch only the selected remote would be great (followup, but can reuse fetch popup)

@extrawurst

This comment was marked as resolved.

@extrawurst

This comment was marked as resolved.

@extrawurst extrawurst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok i finally had time for an in-depth review. i love this feature already just for reviewing PRs :)
Lets get it over the finish line. i believe my remarks are all no biggies but should be addressed before we can merge it.
good job!

Comment thread CHANGELOG.md Outdated
Comment thread src/popups/create_remote.rs Outdated
Comment thread src/popups/remotelist.rs
Comment thread src/popups/remotelist.rs Outdated
Comment thread src/popups/remotelist.rs
Comment thread src/strings.rs Outdated
@robin-thoene robin-thoene force-pushed the remotes-popup branch 3 times, most recently from 735c147 to 0eee47f Compare September 17, 2024 15:41
@robin-thoene

This comment was marked as outdated.

@robin-thoene

This comment was marked as resolved.

@extrawurst

This comment was marked as outdated.

@extrawurst

This comment was marked as resolved.

@extrawurst

This comment was marked as resolved.

@extrawurst

This comment was marked as resolved.

@extrawurst

This comment was marked as resolved.

@extrawurst

This comment was marked as resolved.

Comment thread CHANGELOG.md Outdated
@extrawurst extrawurst merged commit d4f9400 into gitui-org:master Sep 18, 2024
@extrawurst

Copy link
Copy Markdown
Collaborator

Thank you so much 🎉

@robin-thoene

Copy link
Copy Markdown
Contributor Author

Thank you so much for the review, guidance and help!

@robin-thoene robin-thoene deleted the remotes-popup branch September 23, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List Remotes Popup

2 participants