Skip to content

Add DNS provider for Dynadot#3125

Merged
ldez merged 3 commits into
go-acme:mainfrom
rowanchen-com:feat/dns/dynadot
May 22, 2026
Merged

Add DNS provider for Dynadot#3125
ldez merged 3 commits into
go-acme:mainfrom
rowanchen-com:feat/dns/dynadot

Conversation

@rowanchen-com

@rowanchen-com rowanchen-com commented May 22, 2026

Copy link
Copy Markdown
Contributor

My English is not strong, so I'll keep this short.
The implementation follows the spaceship/hostinger style.

Closes #1397

@ldez ldez force-pushed the feat/dns/dynadot branch from 3fdc5a6 to 79c1798 Compare May 22, 2026 15:37

@ldez ldez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am being kind with you: I reviewed the PR despite you not having respected all the constraints I had set for you.
This makes me sad, but at least you have tried.

@ldez ldez merged commit 1a66c8c into go-acme:main May 22, 2026
7 checks passed
@rowanchen-com

Copy link
Copy Markdown
Contributor Author

I am being kind with you: I reviewed the PR despite you not having respected all the constraints I had set for you. This makes me sad, but at least you have tried.

Thank you. Sorry I did not follow the rules. Next time I will do better.

@ldez ldez modified the milestones: unreleased-v5, v5.1 May 22, 2026
rowanchen-com added a commit to rowanchen-com/1Panel that referenced this pull request May 23, 2026
Dynadot was added to upstream lego in v5.1.0
(go-acme/lego#3125). Wire it into the same DNS provider
switch the other 25 providers use, and surface it in the frontend so
users can pick it in the DNS account dialog.

DnsPod is removed from the DNS provider list. lego v5 has no DnsPod
implementation; the previous frontend already showed a deprecation
hint pointing at TencentCloud, which is now the recommended way to
manage DNSPod-hosted zones (the underlying API is the same).
rowanchen-com added a commit to rowanchen-com/1Panel that referenced this pull request May 23, 2026
Dynadot was added to upstream lego in v5.1.0
(go-acme/lego#3125). Wire it into the same DNS provider
switch the other 25 providers use, and surface it in the frontend so
users can pick it in the DNS account dialog.

DnsPod is removed from the DNS provider list. lego v5 has no DnsPod
implementation; the previous frontend already showed a deprecation
hint pointing at TencentCloud, which is now the recommended way to
manage DNSPod-hosted zones (the underlying API is the same).
rowanchen-com added a commit to rowanchen-com/1Panel that referenced this pull request May 25, 2026
Dynadot was added to upstream lego in v5.1.0
(go-acme/lego#3125). Wire it into the same DNS provider
switch the other 25 providers use, and surface it in the frontend so
users can pick it in the DNS account dialog.

DnsPod is removed from the DNS provider list. lego v5 has no DnsPod
implementation; the previous frontend already showed a deprecation
hint pointing at TencentCloud, which is now the recommended way to
manage DNSPod-hosted zones (the underlying API is the same).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Add support for DynaDot DNS Provider

2 participants