Output information about skipped tests in xml output#2767
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
The extra tests check that the xml output is correct when a failure occurs before skipping, and that the right skip message is added to the file. The json file had to be fixed because it's the same executable.
|
Please sign the CLA and make sure the tests pass. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
6490c80 to
807317f
Compare
|
@zhangxy988 The tests are passing, but the travis check remains pending. I don't know how I can solve this. The CLA has been resolved. |
|
Fixes #2728 |
807317f to
7c8ab52
Compare
|
Thank you, we have started internal review. Please don’t push any more changes into this PR as they might be overwritten. (313176466) |
PiperOrigin-RevId: 313386267
PiperOrigin-RevId: 313386267
This pull request adds two things to the xml output:
I followed the JUnit description in https://llg.cubic.org/docs/junit/