Remove lerna#4368
Merged
Merged
Conversation
Contributor
|
I looked into the issues and this seems like the best solution to me as well. Didn't even think about the yarn issue but it totally makes sense. |
|
still running into this issue, would be great to get some progress here |
Same using NPM, can't install can't find modules postinstall |
Closed
This was referenced Aug 1, 2023
Merged
Merged
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* move postinstall script to update package lock * removed lerna * build works * update scripts * fixed workspace selectors * fixed fidelity tests * fixed local modelviewer.dev * fix deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4380
The main purpose of this was to fix the postinstall script that's been giving us trouble - I think the main problem is it really needs to be at the root level rather than in the model-viewer package. However, during this update I found myself in a nasty catch-22 where the bootstrap process was somehow getting the old package.json and still looking for a non-existant postinstall script. I remembered that lerna bootstrap has been deprecated for some time, so figured this might be the right time to update to npm workspaces.
Since this is related to #4260 and #4363, @Beilinson and @btopro can you review this for me?