New three-gpu-pathtracer screenshots#4696
Merged
Merged
Conversation
gkjohnson
commented
Mar 5, 2024
Contributor
Author
There was a problem hiding this comment.
The reason we see a faint red "X" on the middle panels is because there are two planes facing each other so the color of the X is reflecting off the checkmark plane. Here's a double sided shot to show whats happening:
elalish
approved these changes
Mar 13, 2024
elalish
left a comment
Contributor
There was a problem hiding this comment.
Thank you! Looking great.
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* Update config * Update screenshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
#4686
Add new screenshots for three-gpu-pathtracer