remove DPR cap#4896
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the history of MV, we have only taken device pixel ratio (DPR) into account when a
<meta viewport>tag was present on the page, since the default page scaling that happens on mobile browsers could cause us to render at far too high a pixel density and kill performance. However, we've now had dynamic render scaling built in for some time that dynamically reduces pixel density to maintain frame rate as necessary, and this is a much safer and more general approach to the problem.We've occasionally run into pages that don't both to put a
<meta viewport>tag in, even though they are modern pages, and high pixel-density screens are more and more common even on desktop, so I think at this point it's safer to remove our heuristic. This will ensure we are rendering at screen resolution across devices, and only downsampling under performance constraints.