Added the ability to run and combine multiple animations simultaneously#4979
Merged
Conversation
…ly, upgraded to threejs r171, and updated packages to the latest version.
elalish
suggested changes
Dec 23, 2024
elalish
left a comment
Contributor
There was a problem hiding this comment.
Wow, this is quite a feature, thank you! To make this easier to review and merge, would you be so kind as to split the dependency updates into a separate PR from the animation work? We should be able to quickly merge the updates, but we'll probably need some back-and-forth on the API change. Honestly, it's looking really good though!
…ove appendAnimation method, format codes with clang-format style and fix other requested changes in google#4979 pull request
…of appendAnimation function, improve modelviewer.dev styles and revert dependencies version
Contributor
Author
|
Hey there! Here's my rework of that PR message: 👋 Thank you for the helpful feedback! I've made the following changes in this PR:
Let me know if any further adjustments are needed! 🙂 |
Contributor
|
Thanks! As this is my last day (see #4975), I'm going to pass this on to one our other maintainers, @diegoteran, who I already talked to about this PR. Looks like a promising feature! |
…improve general performance
…ncy error when installing in postprocessing
Collaborator
|
@mohammadbaghaei Hey, this is great! Give me a few days and then I'll review it (scheduling and deciding things with the team now that Emmett is not here) and I'll merge it to have it ready for the next MV release. Thank you so much! |
…ditor, improve modelviewer.dev hamburger menu
5 tasks
diegoteran
approved these changes
Feb 3, 2025
diegoteran
pushed a commit
that referenced
this pull request
Feb 24, 2025
* Added the ability to run and combine multiple animations simultaneously, upgraded to threejs r171, and updated packages to the latest version. * fix build warnings and errors and replace rollup-plugin-polyfill with swc * fix fidelity-tests chrome error * fix chrome install error on fidelity-tests * fix fidelity-tests error on Fix dependencies step * add no-sandbox args to puppeteer.launch * cleanup github workflow * add example for appendAnimation, improve modelviewer.dev styles, improve appendAnimation method, format codes with clang-format style and fix other requested changes in #4979 pull request * Fix all requested changes in #4979 PR, improve the flexibility of appendAnimation function, improve modelviewer.dev styles and revert dependencies version * improve detachAnimation flexibility * update dependencies to latest version * fix #4960 issue * Fix animation skipping when updating with appendAnimation method and improve general performance * Upgrade to three.js r172 and update dependencies and fix peer dependency error when installing in postprocessing * add Cineon, Reinhard, Linear, none tone mapping options and update documention * revert peetDependencies change * fix package-lock error * fix repetitions and pingpong update bug * add time option to appendAnimation function * fix editor "js-beautify" invalid src * update dependencies * improve editor and modelviewer.dev styles, add mobile responsive to editor, improve modelviewer.dev hamburger menu * update dependencies * add ar-usdz-max-texture-size (related #4984 issue) * try fix deploy error, upgrade to three.js r173 and update all dependencies, fix ar-usdz-docs.json "max-texture-size" attribute defualt value
diegoteran
pushed a commit
that referenced
this pull request
Apr 8, 2025
* Added the ability to run and combine multiple animations simultaneously, upgraded to threejs r171, and updated packages to the latest version. * fix build warnings and errors and replace rollup-plugin-polyfill with swc * fix fidelity-tests chrome error * fix chrome install error on fidelity-tests * fix fidelity-tests error on Fix dependencies step * add no-sandbox args to puppeteer.launch * cleanup github workflow * add example for appendAnimation, improve modelviewer.dev styles, improve appendAnimation method, format codes with clang-format style and fix other requested changes in #4979 pull request * Fix all requested changes in #4979 PR, improve the flexibility of appendAnimation function, improve modelviewer.dev styles and revert dependencies version * improve detachAnimation flexibility * update dependencies to latest version * fix #4960 issue * Fix animation skipping when updating with appendAnimation method and improve general performance * Upgrade to three.js r172 and update dependencies and fix peer dependency error when installing in postprocessing * add Cineon, Reinhard, Linear, none tone mapping options and update documention * revert peetDependencies change * fix package-lock error * fix repetitions and pingpong update bug * add time option to appendAnimation function * fix editor "js-beautify" invalid src * update dependencies * improve editor and modelviewer.dev styles, add mobile responsive to editor, improve modelviewer.dev hamburger menu * update dependencies * add ar-usdz-max-texture-size (related #4984 issue) * try fix deploy error, upgrade to three.js r173 and update all dependencies, fix ar-usdz-docs.json "max-texture-size" attribute defualt value * update documention threejs version * fix mobile responsive bugs and improve snippet viewer code structure * upgrade to threejs r174 and update all dependencies * add terser to modelviewer.dev * fix build error and update all dependencies * try to fix test error * fix test error and update dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to run and combine multiple animations simultaneously with
appendAnimationanddetachAnimationmethods, updated documentation, upgrade to three.js r171 and update all dependencies to latest version