Skip to content

Fix building CPython after python/cpython#107026#10758

Merged
jonathanmetzman merged 1 commit into
google:masterfrom
illia-v:patch-1
Jul 31, 2023
Merged

Fix building CPython after python/cpython#107026#10758
jonathanmetzman merged 1 commit into
google:masterfrom
illia-v:patch-1

Conversation

@illia-v

@illia-v illia-v commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Modules/_xxtestfuzz/fuzzer.c in CPython started using private API in python/cpython@89f9875#diff-a22ac7579f23068e0c6bcacf1086ee962fdf8e68725cf0510b42d0a389cf1efd.

This made fuzzing builds fail https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=60831.

Including needed header files fixes the error.

`Modules/_xxtestfuzz/fuzzer.c` in CPython started using private API in python/cpython@89f9875#diff-a22ac7579f23068e0c6bcacf1086ee962fdf8e68725cf0510b42d0a389cf1efd.

This made fuzzing builds fail https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=60831.

Including needed header files fixes the error.
@google-cla

google-cla Bot commented Jul 28, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions

Copy link
Copy Markdown

illia-v is a new contributor to projects/cpython3. The PR must be approved by known contributors before it can be merged. The past contributors are: jonathanmetzman, gpshead, DavidKorczynski, oliverchang, devtty1er, Dor1s, ammaraskar (unverified), alex (unverified), ssbr (unverified)

@jonathanmetzman

Copy link
Copy Markdown
Contributor

illia-v is a new contributor to projects/cpython3. The PR must be approved by known contributors before it can be merged. The past contributors are: jonathanmetzman, gpshead, DavidKorczynski, oliverchang, devtty1er, Dor1s, ammaraskar (unverified), alex (unverified), ssbr (unverified)

@hogo6002 Can we filter out certain names from this list? A lot of these are maintainers that do mass changes but don't have particular knowledge of the project (me for example)

@jonathanmetzman

Copy link
Copy Markdown
Contributor

Other than that, the list is great

@jonathanmetzman

Copy link
Copy Markdown
Contributor

@ammaraskar @alex @gpshead do you approve?

@ammaraskar

Copy link
Copy Markdown
Contributor

LGTM

@alex

alex commented Jul 31, 2023 via email

Copy link
Copy Markdown
Contributor

@jonathanmetzman jonathanmetzman merged commit d9270d0 into google:master Jul 31, 2023
@hogo6002

hogo6002 commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

illia-v is a new contributor to projects/cpython3. The PR must be approved by known contributors before it can be merged. The past contributors are: jonathanmetzman, gpshead, DavidKorczynski, oliverchang, devtty1er, Dor1s, ammaraskar (unverified), alex (unverified), ssbr (unverified)

@hogo6002 Can we filter out certain names from this list? A lot of these are maintainers that do mass changes but don't have particular knowledge of the project (me for example)

Sure, I will remove maintainers from this list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants