Write variable vertical metrics#1489
Closed
Hoolean wants to merge 5 commits into
Closed
Conversation
Contributor
Author
|
(the failing tests are from the issue described above) |
Contributor
Author
|
A small update: this can be rebased on |
Contributor
|
I apologize, I didn't notice this and managed to do duplicative work in #1666, including tests and code sharing. @anthrotype has volunteered to port the remaining things we need from here, such as gvar phantom points, as follow-on PRs. Thank you for your work on vertical, without what you started in #1388, the addition of interpolated metrics, etc we would likely still be punting on it. Instead I'm hoping to see a nice +x on crater soon :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final puzzle piece from #1388 (🎊): writing variable heights to eliminate the remaining diffs for vertical fonts on crater. In particular, the main changes in this PR are to:
HVARfor reuse to writeVVARgvarphantom pointsQuestion before merging
This PR will need furnishing with tests. However, before doing so, there is one issue I would like to address:
When a glyph instance's height or vertical origin is absent, the default value must be derived from the global metrics at that location. This can sometimes crash fontc, as outlines may be at positions where global metrics are undefined, e.g. for designspace sparse layers or Glyphsapp brace layers, and fontc does not implement metrics interpolation yet.
What solution do we want to get vertical metrics over the line?