[crater] Explicitly call python3 instead of python#1561
Merged
Conversation
rsheeter
approved these changes
Jul 14, 2025
rsheeter
left a comment
Contributor
There was a problem hiding this comment.
If you expect these to be run in the context of a venv then the explicit python3 is not necessary. LGTM in case that's not the expectation.
Member
Author
|
just aiming for maximal portability? but 🤷 |
Member
but python3 will also be present in the venv, alongside the unqualified python, so this is ok (well, at least for Linux or macOS). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.