fix non-determinism in FeatureParamsCharacterVariants nameIDs#1572
Merged
Conversation
Part of fixing #1568 We were iterating over a HashMap items while incrementally assigning nameIDs for Feature Parameters Character Variants, but the iteration order changes each time, best to use a BTreeMap in this case
00c6112 to
086b5ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fixing #1568
We were iterating over HashMap's items while incrementally assigning new nameIDs for the Feature Parameters Character Variants, but the iteration order changes each time, so best to use a BTreeMap in this case
fontc/fea-rs/src/compile/features.rs
Lines 256 to 259 in 00c6112
After applying this patch, running the following command multiple times produces the same GSUB table:
JMM