Attempt to fix non-deterministic GSUB compilation#1573
Merged
Conversation
0da84f3 to
120cc17
Compare
120cc17 to
b67baa8
Compare
This ensures we produces the same GSUB FeatureVariations output across builds. Doesn't match 100% glyphsLib yet, at least for Playfair.glyphspackage, I still see a lot of ttx diffs in GSUB... But it's an improvement in the sense that fontc's own output is now stable. [align_bracket_layers] minor: move getting master layer outside of the loop prefer using IndexMap/IndexSet to HashMap/HashSet + sorting wip
b23dad1 to
d7218a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix #1568
not 100% sure of these changes yet, but at least I can get fontc to produce the same GSUB when run multiple times.
I'm using Playfair.glyphspackage for testing and comparing against glyphsLib.