[kern] Ignore feature markers from ungenerated features#1574
Merged
Conversation
This was the cause of a diff in NotoSerifTibetan: that FEA contained an a `kern` feature, but the feature writer was only generating a `dist` feature. In this case it should not consider the presense of the `kern` feature when determining where to insert the lookups for `dist`.
anthrotype
approved these changes
Jul 23, 2025
cmyr
added a commit
that referenced
this pull request
Aug 21, 2025
This is the marks version of #1574, and should fix a diff in NotoSansKannada.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was the cause of a diff in NotoSerifTibetan: that FEA contained an a
kernfeature, but the feature writer was only generating adistfeature. In this case it should not consider the presense of thekernfeature when determining where to insert the lookups fordist.This should get us at least a +1 on crater :)
JMM