Skip to content

Fix avar tests by writing all mappings in instances#1582

Merged
cmyr merged 1 commit into
mainfrom
avr
Aug 6, 2025
Merged

Fix avar tests by writing all mappings in instances#1582
cmyr merged 1 commit into
mainfrom
avr

Conversation

@rsheeter

@rsheeter rsheeter commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Exhibits how to fix compile_glyphs_font_with_avar and strikeout_size_fallback

@rsheeter rsheeter changed the title Fix compile_glyphs_font_with_avar by writing all mappings in instances Fix avar tests by writing all mappings in instances Aug 4, 2025
These files were incomplete and couldn't actually be compiled by
fontmake; now they can.

@cmyr cmyr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. I took the liberty of rebasing this on main and we can just merge it as-is, since I think it's an improvement independent of #1555.

@cmyr cmyr changed the base branch from avoid-master-mapping-if-possible to main August 6, 2025 18:38
@cmyr cmyr added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit bb3a157 Aug 6, 2025
12 checks passed
@cmyr cmyr deleted the avr branch August 6, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants