[fontir] Tweak glyph ir logging#1589
Conversation
| } | ||
| trace!( | ||
| "Flatten {} {:?}", | ||
| log::debug!( |
There was a problem hiding this comment.
I think this should stay trace, and probably the flattening non-export components of should also be trace?
There was a problem hiding this comment.
What is your heuristic for making that determination?
my issue with trace is that if you turn it on our logging is incredibly verbose, and it's very hard to find anything. These operations don't happen that often, and I often want to see if they happen because they end up being a common source of glyf/gvar difference.
There was a problem hiding this comment.
It's not a hard rule but broadly I would expect:
- Debug is safe to turn on globally. It'll be noisy but not completely unusable
- Trace is too noisy to turn on globally, it's very detailed and you shoudl turn it on only for the module you are troubleshooting (e.g.
export RUST_LOG=warn,fontir::glyph=debug)- Aside: Invalid kern side seems to be very common, to the point I wonder if it's really a warning
Are you turning trace on globally or for a specific module?
There was a problem hiding this comment.
I'm basically not turning trace on at all 😅
| trace!( | ||
| "Flatten {} {:?}", | ||
| log::debug!( | ||
| "flattening {} (components: {:?})", |
There was a problem hiding this comment.
Nit: capitalization of the first word of the log message is inconsistent. I think mostly we capitalize so Flattening
7d5b545 to
b564845
Compare
b564845 to
68d370f
Compare
Tiny fixups to try and make some of these things more visible, as I try to debug a funny component flattening issue.
JMM