ttx_diff: use more specific xpath to select nameID=25#1596
Merged
Conversation
I am not entirely sure why, but after #1590 running ttx_diff.py on Kablammo.glyphs gives a weird "lxml.etree.XPathEvalError: unknown error". Maybe the xml file is to big and the xpath expression too broad, i am not entirely sure. Making the xpath expression more selective and explicit seems fixes the error.
Contributor
|
That ... is super weird. Seems like a bug. ty for fixing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not entirely sure why, but after #1590 running ttx_diff.py on Kablammo.glyphs gives a weird "lxml.etree.XPathEvalError: unknown error". Notice the +2 in red under https://googlefonts.github.io/fontc_crater/#other-failures
Maybe the xml file is to big and the xpath expression too broad? i am not entirely sure. But making the xpath expression more selective and explicit seems to fix the error.
JMM