[glyphs] Update corner erasure code#1601
Merged
Merged
Conversation
rsheeter
approved these changes
Aug 15, 2025
rsheeter
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I assume we should time landing so this goes in alongside the glyphsLib update to avoid a negative delta on crater?
Member
Author
|
gonna do a sanity crater run but yea we can land them both on monday? |
The glyphs.app implementation has changed slightly from when this code was first ported.
714333c to
911779f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The glyphs.app implementation has changed slightly from when this code was first ported.
see #1600 (comment)
I'll have a glyphsLib patch up that matches this shortly.