Skip to content

[crater] Print per-target runtime#1603

Merged
cmyr merged 1 commit into
mainfrom
crater-timestamps
Aug 21, 2025
Merged

[crater] Print per-target runtime#1603
cmyr merged 1 commit into
mainfrom
crater-timestamps

Conversation

@cmyr

@cmyr cmyr commented Aug 19, 2025

Copy link
Copy Markdown
Member

It's otherwise tricky to see what targets take the longest to run, which is something I'm curious about.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @cmyr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the crater tool by introducing detailed logging and reporting of individual target execution times. The primary goal is to provide better visibility into which targets consume the most time, aiding in performance analysis and optimization efforts.

Highlights

  • Improved Time Measurement and Reporting: A new utility function human_readable_duration has been introduced to format std::time::Duration into a human-readable string (e.g., "XhYmZ.ZZs").
  • Per-Target Runtime Logging: The run_all function now records and logs the execution time for each individual target, making it easier to identify slow-running components.
  • Centralized Duration Formatting: The previous custom time formatting logic has been replaced with the new human_readable_duration utility across various parts of the codebase, including CI and HTML reporting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds per-target runtime printing, which is a great feature for identifying performance bottlenecks. The implementation introduces a reusable human_readable_duration function with tests, which is well done. My main feedback is a suggestion to refactor the time calculation logic within human_readable_duration to improve readability and maintainability by using the modulo operator.

Comment thread fontc_crater/src/main.rs
It's otherwise tricky to see what targets take the longest to run, which
is something I'm curious about.
@cmyr cmyr force-pushed the crater-timestamps branch from 4c6ffa2 to 81fae39 Compare August 19, 2025 16:20
@PauloRosarioData

Copy link
Copy Markdown

LGTM

@PauloRosarioData PauloRosarioData left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmyr cmyr added this pull request to the merge queue Aug 21, 2025
Merged via the queue into main with commit c1be13d Aug 21, 2025
12 checks passed
@cmyr cmyr deleted the crater-timestamps branch August 21, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants