[glyf] Only set USE_MY_METRICS flag for static fonts, not variable fonts#1615
Merged
Conversation
The USE_MY_METRICS flag is primarily useful for hinted fonts where composite glyphs should reuse the hinted metrics of their components. Since fontc doesn't support hinting, and the flag can be dangerous in variable fonts where composite and component metrics may differ across masters, we now only set the flag for static fonts to match fontmake's legacy behavior. We plan to change fontmake to do the same for variable fonts as well. Fixes #1614
rsheeter
reviewed
Aug 26, 2025
bd08b9d to
75134a7
Compare
rsheeter
approved these changes
Aug 26, 2025
Member
Author
|
we should hold merging this until we do the corresponding change in ufo2ft |
Member
Author
|
i'll work on it tomorrow |
Member
Author
This was referenced Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The USE_MY_METRICS flag is primarily useful for hinted fonts where composite glyphs should reuse the hinted metrics of one of their components.
Since fontc doesn't support hinting, and the flag can be dangerous in variable fonts where composite and component metrics may differ across masters, we now only set the flag for static fonts to match fontmake's legacy behavior.
We plan to change fontmake to do the same for variable fonts as well.
Fixes #1614