Skip to content

also bump patch for the rest of fontc crates#1621

Merged
anthrotype merged 1 commit into
mainfrom
bump-versions
Sep 5, 2025
Merged

also bump patch for the rest of fontc crates#1621
anthrotype merged 1 commit into
mainfrom
bump-versions

Conversation

@anthrotype

Copy link
Copy Markdown
Member

... they also use write-fonts, and if we don't bump and publish these as well, we may get errors about types coming multiple versions of shared crates.

E.g. I tried to publish fea-rs but got the following error:

   Compiling fea-rs v0.20.3 (/private/tmp/fontc/target/package/fea-rs-0.20.3)
error[E0308]: mismatched types
    --> src/compile/compile_ctx.rs:1275:28
     |
1275 |                 pos.insert(tag, coord);
     |                     ------ ^^^ expected `font_types::tag::Tag`, found `write_fonts::font_types::Tag`
     |                     |
     |                     arguments to this method are incorrect
     |
note: two different versions of crate `font_types` are being used; two types coming from two different versions of the same crate are different types even if they look the same
    --> /Users/clupo/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/font-types-0.10.0/src/tag.rs:23:1
     |
23   | pub struct Tag([u8; 4]);
     | ^^^^^^^^^^^^^^ this is the found type `write_fonts::font_types::Tag`
     |
    ::: /Users/clupo/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/font-types-0.9.0/src/tag.rs:23:1
     |
23   | pub struct Tag([u8; 4]);
     | ^^^^^^^^^^^^^^ this is the expected type `font_types::tag::Tag`
     |
    ::: src/common.rs:5:5
     |
5    | use fontdrasil::types::GlyphName;
     |     ---------- one version of crate `font_types` used here, as a dependency of crate `write_fonts`
6    | use write_fonts::tables::gpos::builders::AnchorBuilder;
     |     ----------- one version of crate `font_types` used here, as a dependency of crate `write_fonts`
     = help: you can use `cargo tree` to explore your dependency tree
note: method defined here
    --> /Users/clupo/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/fontdrasil-0.2.2/src/coords.rs:318:12
     |
318  |     pub fn insert(&mut self, tag: Tag, pos: Coord<Space>) -> &mut Location<...
     |            ^^^^^^

For more information about this error, try `rustc --explain E0308`.
error: could not compile `fea-rs` (lib) due to 1 previous error
error: failed to verify package tarball

Apparently the old fontdrasil from crates uses an old write-fonts which in turns uses an old font-types, etc.

... they also use write-fonts, and if we don't bump and publish these as well, we may get errors about types coming multiple versions of shared crates.
@rsheeter

rsheeter commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

we may get errors about types coming multiple versions of shared crates

We might want to add ci to check for multiple versions of things, at least for fontations things, in the tree? - if you agree lets file an issue.

@anthrotype anthrotype added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit 33877c9 Sep 5, 2025
12 checks passed
@anthrotype anthrotype deleted the bump-versions branch September 5, 2025 16:06
@anthrotype

Copy link
Copy Markdown
Member Author

sure.. it's not clear to me why CI didn't catch this already. I only noticed when I was running the release script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants