also bump patch for the rest of fontc crates#1621
Merged
Merged
Conversation
... they also use write-fonts, and if we don't bump and publish these as well, we may get errors about types coming multiple versions of shared crates.
rsheeter
approved these changes
Sep 5, 2025
Contributor
We might want to add ci to check for multiple versions of things, at least for fontations things, in the tree? - if you agree lets file an issue. |
Member
Author
|
sure.. it's not clear to me why CI didn't catch this already. I only noticed when I was running the release script |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... they also use write-fonts, and if we don't bump and publish these as well, we may get errors about types coming multiple versions of shared crates.
E.g. I tried to publish fea-rs but got the following error:
Apparently the old fontdrasil from crates uses an old write-fonts which in turns uses an old font-types, etc.