[fea] Track context when parsing include files#1634
Merged
Conversation
Previously we would always parse files (including files referenced via `include` statements) as if they were standalone FEA. This means that we would only accept statements that were valid at the top-level FEA scope. Some sources, however, use `include` statements inside of feature blocks, where additional statements are permitted. This patch keeps track of the type of the node in which an include statement is encountered, and picks an entry point for parsing that file based on this scope. Currently we just support 'top level' and 'feature', which unblocks us; we can expand on this as needed.
rsheeter
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would always parse files (including files referenced via
includestatements) as if they were standalone FEA. This means that we would only accept statements that were valid at the top-level FEA scope.Some sources, however, use
includestatements inside of feature blocks, where additional statements are permitted.This patch keeps track of the type of the node in which an include statement is encountered, and picks an entry point for parsing that file based on this scope.
Currently we just support 'top level' and 'feature', which unblocks us; we can expand on this as needed.
This fixes another fontc crash.