ttx_diff: make repository root check more robust#1641
Merged
Conversation
The script previously checked if the current directory was named "fontc" to ensure it was running from the repository root. This check is too restrictive and fails when using `git worktree` (for checking out a branch into separate directories) or if the repository itself was cloned with a different name than "fontc". Replace the directory name check with a verification for the existence of `fontc/Cargo.toml`. This is a more reliable way to confirm the script is being executed from the correct location without depending on the name of the root folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script previously checked if the current directory was named "fontc" to ensure it was running from the repository root.
This check is too restrictive and fails when using
git worktree(for checking out a branch into separate directories) or if the repository itself was cloned with a different name than "fontc".Replace the directory name check with a verification for the existence of
fontc/Cargo.toml. This is a more reliable way to confirm the script is being executed from the correct location without depending on the name of the root folder.JMM