[ir] Also interpolate width/height etc in instances#1658
Merged
Conversation
2f2065b to
f809ca5
Compare
anthrotype
reviewed
Sep 26, 2025
anthrotype
reviewed
Sep 26, 2025
| /// | ||
| /// - the (x,y) values of points in any contours, in order | ||
| /// - the decomposed transform of any components, in order | ||
| /// - the width, height, and vertical origin (if present). |
Member
There was a problem hiding this comment.
anchor positions also interpolate... in fact Glyphs.app anchor propagation works even when a composite glyph inherit anchors from a component that doesn't have a given location, which gets interpolated on the fly
Member
Author
There was a problem hiding this comment.
hm yea anchors aren't part of ir::Glyph, so we'll need to do that separately (opened #1661)
anthrotype
approved these changes
Sep 26, 2025
This also more generally reworks the interpolation code so that it all lives in one place (methods on `GlyphInstance`).
Base automatically changed from
ensure_composite_defined_at_comp_location
to
main
September 26, 2025 17:22
f809ca5 to
f0a4409
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also more generally reworks the interpolation code so that it all lives in one place (methods on
GlyphInstance).