[ir] Decompose components with intermediate layers#1660
Merged
Conversation
...and actually make sure that the final glyph is also defined at all the positions defined by any component.
anthrotype
approved these changes
Sep 26, 2025
anthrotype
added a commit
that referenced
this pull request
Apr 22, 2026
Remove the ensure_composite_defined_at_component_locations call from flatten_non_export_components_for_glyph. The flattening loop only needs to process the composite's own source locations — get_or_instantiate_instance already handles resolving components at those locations. The call was added in PR #1657 (for #1592) but became redundant when PR #1660 added the same call to convert_components_to_contours, which handles the decomposition step where the extra sources are actually needed. With the call in both places, virtual sources from component brace layers leaked into the composite's source map and produced spurious gvar intermediate tuples. Fixes #1840
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on top of #1659