[ir] Don't round when computing deltas for intermediates#1670
Merged
Conversation
rsheeter
reviewed
Sep 30, 2025
rsheeter
approved these changes
Sep 30, 2025
This was a sneaky little bug: the rounding of intermediate values caused us to incorrectly interpolate affine transformations that contained fractional values.
2924779 to
06d631d
Compare
anthrotype
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a sneaky little bug: the rounding of intermediate values caused us to incorrectly interpolate affine transformations that contained fractional values.
This matches ufo2ft, which sets
round_geometry=Falseon the instantiator.This resolves a number of gvar diffs, and Should give us at least a +4 identical.