[glyphs] Fix logic bug around bracket glyph components#1671
Merged
Conversation
bf7f9c3 to
0a2522b
Compare
rsheeter
reviewed
Sep 30, 2025
rsheeter
approved these changes
Sep 30, 2025
0a2522b to
ea493c8
Compare
We were deciding whether to replace a bracket glyph's component with a an appropriate bracket glyph for that component based on whether the two alternates had equivalent names, instead of whether the replacements applied in equivalent regions.
ea493c8 to
f8f51ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were deciding whether to replace a bracket glyph's component with a an appropriate bracket glyph for that component based on whether the two alternates had equivalent names, instead of whether the replacements applied in equivalent regions.