[glyphs] Instantiate smart components depth-first#1711
Merged
Conversation
cdc89b8 to
d00550a
Compare
That is, ensure that a smart component that has its own smart components will get them instantiated before it gets instantiated itself.
d00550a to
827c5b3
Compare
anthrotype
approved these changes
Oct 23, 2025
anthrotype
left a comment
Member
There was a problem hiding this comment.
LGTM but let's wait to merge before glyphsLib catches up?
matches glyphsLib
Member
|
googlefonts/glyphsLib#1113 is merged, we can merge this as soon as we bump glyphsLib 6.12.2 |
anthrotype
added a commit
that referenced
this pull request
Oct 24, 2025
supports nested smart components googlefonts/glyphsLib#1113 required for #1711
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That is, ensure that a smart component that has its own smart components will get them instantiated before it gets instantiated itself.
This improves our own behaviour but doesn't get us any green numbers because glyphsLib also doesn't handle this correctly, see googlefonts/glyphsLib#1111