[crater] Fixup cache invalidation logic#1727
Merged
Merged
Conversation
anthrotype
reviewed
Nov 4, 2025
Previously we would use the python dependencies (the output of `pip freeze`) as well as the presence of any changes to ttx_diff since the previously run commit to invalidate caches. As ttx_diff is now a python package, and is installed from a local path, it ins included in the output of pip freeze with a sha appeneded, and this sha changes on each commit to the fontc repo. The solution here is just to manually remove ttx_diff from the output of pip freeze, since changes are still tracked independently.
091a851 to
8348a1c
Compare
anthrotype
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would use the python dependencies (the output of
pip freeze) as well as the presence of any changes to ttx_diff since the previously run commit to invalidate caches.As ttx_diff is now a python package, and is installed from a local path, it ins included in the output of pip freeze with a sha appeneded, and this sha changes on each commit to the fontc repo.
The solution here is just to manually remove ttx_diff from the output of pip freeze, since changes are still tracked independently.