[glyphs] Ensure brackets have axis rules for each axis#1731
Merged
Conversation
In glyphs2, a bracket layer can only reference a value on a single axis (from experimentation, it seems to only work with the first axis) and so in the case where multiple axes are defined, we need to add empty axis rules for the additional axes. This fixes one crater diff.
f2b1bdb to
2fc4af8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In glyphs2, a bracket layer can only reference a value on a single axis (from experimentation, it seems to only work with the first axis) and so in the case where multiple axes are defined, we need to add empty axis rules for the additional axes.
This fixes one crater diff.