How to search Chinese character ?

[sisrfeng]

LESSCHARSET=utf-8 less myfile does not work

Thx !

[gwsw]

Can you describe in what way it is not working, and also describe what operating system and terminal you are using? Searching for hanzi text on a Terminator terminal on Linux seems to work fine for me.

[Konstantin-Glukhov]

Here are the screenshots of less working on Linux:

less Japanese.txt

Enter a search text in Japanese and hit Enter:

Search results are highlighted:

Here are the screenshots of less hanging on Windows (results are the same in both cmd.exe and PowerShell.exe):

Open a file with less:

Enter a search text in English and hit Enter:

Search results are highlighted:

Attempt to search a text in Japanese:

After hitting "/" and entering the first Japanese character, less becomes unresponsive. After that ESC, Backspace, Ctrl-C or "q" do not work, and less needs to be killed from "Task Manger".

[gwsw]

Ah, I didn't understand from the original report that the problem only happens in the Windows build. @adoxa Jason, do you have any thoughts about this?

[adoxa]

Seems something's going awry with console input. I'm afraid it'll be a while before I can take a closer look.

[gwsw]

Ok, thanks.

[Konstantin-Glukhov]

I tried to run it in VSCode debug mode and it appears that program crashes on screen.c:2850 when calling PeekConsoleInput(tty, &ip, 1, &read), which maps to:

WINBASEAPI
BOOL
WINAPI
PeekConsoleInputW(
    _In_ HANDLE hConsoleInput,
    _Out_writes_(nLength) PINPUT_RECORD lpBuffer,
    _In_ DWORD nLength,
    _Out_ LPDWORD lpNumberOfEventsRead
    );

Unfortunately I cannot step into that function to trace it further.

[Konstantin-Glukhov]

I am not sure if it is a big deal here but there is datatype discrepancy in screen.c:

Currently the structure elements defined as:

struct keyRecord
{
	int ascii;
	int scan;
} currentKey;

but they should be:

struct keyRecord
{
	CHAR ascii;
	WORD scan;
} currentKey;

[adoxa]

Here's a potential fix.

[Konstantin-Glukhov]

I tried the fix, but PeekConsoleInput() still fails with error 233: No process is on the other end of the pipe.

[adoxa]

What pipe? Worked fine for me in Win10 console & Windows Terminal.

[Konstantin-Glukhov]

I have no idea why this error is reported. I am just checking the status returned by PeekConsoleInput() and report GetLastError() if status is 0.

My test is the following:

• uznip less-603.zip
• vcvars32.bat (I have VS17)
• modify screen.c with suggested fix and error reporting
• nmake /f Makefile.wnm
• .\less.exe N:\Tmp\Japanese.txt
• Hit "/"
• Switch to Japanese Input by pressing Alt-Esc
• Hit Backspace twice to get rid off garbage
• Press "=" and select 平和 from popup choice
• Hit Enter

Console freezes with the message "error 233: No process is on the other end of the pipe"

[adoxa]

* Switch to Japanese Input by pressing Alt-Esc

How did you install "Japanese Input"? Does it override Alt-Esc moving the window to the back? I tested by right-clicking to paste in a character (which then also shows up in history).

Console freezes with the message "error 233: No process is on the other end of the pipe"

That's weird, since it's not a pipe, but a console; I added error testing, but none was detected (built from git, with VS2010). What Windows (Terminal) version are you using? I have 10.0.19044.1526 & 1.11.2421.0.

[polluks]

You may try Windows Terminal Preview v1.13.1073
https://github.com/microsoft/terminal/releases

[Konstantin-Glukhov]

Japanese Input is installed by adding a language in windows setup.
I did test copy and paste method too.
My terminal is 10.0.19044.1586
I also tested Windows Terminal preview.
I also tried 64bit build.
Nothing works :)