property alphabetization#15
Conversation
|
I'm not sure about this. This doesn't make the CSS anymore performant or particularly easier to read - but then it's not a big deal either way as it was nearly alphabetical anyway. Generally though, I find the suggestions on http://codeguide.co/#css-declaration-order (by MDO, co-creator of Bootstrap and Senior Director of Design at GitHub) the best advice for ordering property declarations. |
|
Fair enough. However, this file's property declaration order doesn't conform to the code guide that you cited -- rather, it suggests an alphabetic approach. Hence my pull request. |
|
I don't think we ever had a public discussion of the order of the properties in the project CSS. Which is kind of surprising, but I don't remember it ever coming up. I don't follow any pattern at all in my personal or (!!) professional development so I don't have a stake in this game at all. It would be good to have a pattern. |
coliff
left a comment
There was a problem hiding this comment.
I changed my opinion on this after researching the topic. :-) I approve of this change now.
|
@coliff I'd be interested to know what changed your mind and what your opinion is on css property ordering. Or could you perhaps give me some links to articles you found interesting on this topic? ps: Sorry only saw your other post after i posted this. (#16 (comment)) |
Types of changes
Checklist: