This repository was archived by the owner on Dec 17, 2025. It is now read-only.
Consent Manager & Toggle a11y fixes#1030
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: bf4220c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
RubenSandwich
commented
Jun 18, 2024
| } | ||
| aria-expanded={this.state.showCategories[name] ? `true` : `false`} | ||
| aria-controls={ | ||
| this.state.showCategories[name] ? categoryListID : null |
Contributor
Author
There was a problem hiding this comment.
null because we only render the contents of the dropdown if the dropdown is open.
nandereck
approved these changes
Jun 18, 2024
nandereck
left a comment
Contributor
There was a problem hiding this comment.
LGTM - validation steps work perfectly and code looks good! 🏅
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Asana Tasks
Description
Fix a variety of accessiblity issuies around the consent manager:
Testing 🚀
npm install 'https://gitpkg.now.sh/hashicorp/react-components/packages/consent-manager?rn/fix/consent-manager-a11y-fixes'esccloses the modaltabis "focus trapped" in the modal and will not exit itspaceandenter<header>tags within it