Optimize OCBBlockCipher_v149 by replacing Vector with List#1057
Merged
Conversation
This saves about 10% time on AES block processing for AEAD buckets.
bertm
commented
May 11, 2025
| */ | ||
| // NOTE: elements are lazily calculated | ||
| private Vector<byte[]> L; | ||
| private List<byte[]> L; |
Contributor
Author
There was a problem hiding this comment.
This could still be optimized slightly further by using byte[][], but the changes are a bit more complex and not worth the trouble.
Contributor
There was a problem hiding this comment.
As code using a byte[][] would be quite a bit harder to read, I would also suggest leaving this until we notice actual performance problems due to List usage. 🙂
Bombe
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves about 10% time on AES block processing for AEAD buckets.
When combined with #1056 the improvement is even more substantial.