Fix single-byte read() in various InputStream implementations#1058
Merged
Conversation
The return value was not correctly converted from signed byte to unsigned int, leading to potential data corruption. Additionally, remove the single-byte buffer field. Small byte[] creation is cheap and can likely be optimized away by the JVM if this becomes a hot code path.
The return value was not correctly converted from signed byte to unsigned int, leading to potential data corruption. Additionally, remove the single-byte buffer field. Small byte[] creation is cheap and can likely be optimized away by the JVM if this becomes a hot code path.
The counter was erroneously incremented when the end of stream was reached unexpectedly on single-byte read(), but this case was correctly handled for multi-byte read(byte[]). Fix the former by reusing the latter.
The counter was erroneously incremented when the end of stream was reached unexpectedly on single-byte read(), but this case was correctly handled for multi-byte read(byte[]). Fix the former by reusing the latter.
The return value was not correctly converted from signed byte to unsigned int, leading to potential data corruption. Additionally, the fast-path for multi-byte read(byte[]) was not implemented, which could be a performance bottleneck when used as a plain InputStream. Implement multi-byte read and reuse that for single-byte read.
Small byte[] creation is cheap and can likely be optimized away by the JVM if this becomes a hot code path.
Bombe
approved these changes
May 29, 2025
Bombe
left a comment
Contributor
There was a problem hiding this comment.
You have now written the same method about six times (seven, actually, remembering the other PR)… maybe we should put that into some InputStreamUtils helper class?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are multiple places where the read byte is not correctly converted to unsigned int (leading to incorrect data being returned), or where the single-byte
read()path differs from the multi-byteread(byte[])orread(byte[], int, int)path.Additionally, do not fear creating short-lived single-byte buffers - their overhead is minimal and can likely be optimized away to some extent.