Skip to content

Remove unused code and parameters from NodeStats#1069

Merged
ArneBab merged 2 commits into
hyphanet:nextfrom
bertm:nodestats-remove-unused
Jun 22, 2025
Merged

Remove unused code and parameters from NodeStats#1069
ArneBab merged 2 commits into
hyphanet:nextfrom
bertm:nodestats-remove-unused

Conversation

@bertm

@bertm bertm commented May 13, 2025

Copy link
Copy Markdown
Contributor
  • Remove unused arguments for private methods
  • Remove all kinds of unused fields, methods & constructors

Reduces the code size of this rather large class by roughly 110 lines.

@bertm

bertm commented May 13, 2025

Copy link
Copy Markdown
Contributor Author

Note that there more reduction possible in the public methods and fields, but since there's often discussion regarding plugins, this starts with the (effectively) non-public ones.

@Bombe Bombe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhm, love it! ❤️

@ArneBab ArneBab merged commit 5f51c40 into hyphanet:next Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants