Fix rel attribute and add rel values#1072
Merged
Merged
Conversation
bertm
suggested changes
May 17, 2025
bertm
left a comment
Contributor
There was a problem hiding this comment.
This appears to introduce 3 changes, but does so in 1 commit:
- Change
fortoaddAll- this change I'm happy to accept - Fix something in the
relattribute handling - please explain in the commit message for this change what was broken and how it is fixed & make sure to have a test for the improvement - Add new
reltypes, but not all of them - please explain explain in the PR description why we need exactly those to be added (and not some other ones that could also be supported)
In it's current state with the commented out code and the FIXME's unresolved, this PR is not ready to be merged.
I would assume change number 2 in the above list brings most value - if possible, please get that in a mergeable state without the parts that would require further discussion :)
Contributor
Author
|
Originally I just wanted to fix that doubled |
Bombe
approved these changes
Jun 28, 2025
Contributor
|
Merged -- thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix rel attribute and add rel values noopener,nofollow,noreferrer,external,tag
Also fixed code style related to adding items to HashSet.