precompiles: Precompute Miller loop lines for KZG trusted setup point#1537
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1537 +/- ##
=======================================
Coverage 96.97% 96.97%
=======================================
Files 162 163 +1
Lines 14436 14450 +14
Branches 3383 3384 +1
=======================================
+ Hits 13999 14013 +14
Misses 307 307
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
2077394 to
487a42c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
test/unittests/precompiles_kzg_test.cpp:12
std::memcmpis used in this test, but<cstring>is not included. Relying on indirect includes can break builds depending on toolchain/standard library; add#include <cstring>(or<string.h>) near the other includes.
#include <evmc/evmc.hpp>
#include <evmone_precompiles/kzg.hpp>
#include <evmone_precompiles/kzg_setup_g2_1_lines.hpp>
#include <evmone_precompiles/sha256.hpp>
#include <gtest/gtest.h>
#include <intx/intx.hpp>
#include <span>
Precompute the Miller-loop lines for the trusted-setup point [s]₂ and use these (instead of the point) for faster KZG pairing check. The precomputation has been done outside and only the result is stored. The static data size is ~19 KB.
487a42c to
cffbd87
Compare
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precompute the Miller-loop lines for the trusted-setup point [s]₂
and use these (instead of the point) for faster KZG pairing check.
The precomputation has been done outside and only the result is stored.
The static data size is ~19 KB.