test: Match block requests and transaction exceptions in blockchaintest#1560
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1560 +/- ##
==========================================
- Coverage 97.07% 97.07% -0.01%
==========================================
Files 162 162
Lines 14480 14500 +20
Branches 3380 3387 +7
==========================================
+ Hits 14057 14076 +19
- Misses 305 306 +1
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
a871eab to
0c56f7c
Compare
Partly inspect expected block invalidity coming from "expectException". Match request collection errors and at least check if a rejected transaction is expected.
0c56f7c to
dcb4f08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The invalid-block branch silently accepted any transition failure without checking it against the fixture's
expectException. Verify those reasons:INVALID_DEPOSIT_EVENT_LAYOUT,SYSTEM_CONTRACT_EMPTY,SYSTEM_CONTRACT_CALL_FAILED);system_call_block_endnow returns the specific error code, which t8n also reports.TransactionException.*fixture (it stops block processing immediately).